CORS-3835: Add gcp endpoints to the installer config #9363
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@barbacbd: This pull request references CORS-3835 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest-required |
|
Comparing this to #9368, this seems less verbose. I don't have strong feelings, but this strikes me as a better approach. /approve |
openshift-ci
bot
added
the
approved
|
/retest-required |
** Added the endpoints including the name and url to the install config. ** Validate the user entered data.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
** Added validation for the GCP Service Endpoints.
|
@barbacbd: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
** Added the endpoints including the name and url to the install config.
** Added Specific endpoint names that able to be used/customized.
** Added validation for the GCP Service Endpoints.